Fix SQLiteAdapter when changing primary key#954
Merged
Conversation
markstory
reviewed
Nov 11, 2025
src/Db/Adapter/SqliteAdapter.php
Outdated
Comment on lines
1358
to
1363
| } elseif ($matches[2] === 'INTEGER') { | ||
| // INTEGER column without AUTOINCREMENT should stay that way | ||
| $replace = '$1 INTEGER NOT NULL PRIMARY KEY'; | ||
| } else { | ||
| $replace = '$1 $2 NOT NULL PRIMARY KEY'; | ||
| } |
Member
There was a problem hiding this comment.
Isn't this new case redundant as the case on 1362 handles this?
Co-authored-by: Mark Story <mark@mark-story.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: cakephp/phinx#2364
SQLite adapter incorrectly adds
AUTOINCREMENTkeyword to integer columns when changing a table's primary key, even when not explicitly specified.Changes Made
The fix was verified to: